Allon Mureinik has posted comments on this change. Change subject: [WIP] vdsbroker: read vmJobs update from getVmStats call ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/26905/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 389: } Line 390: return vmBalloonInfo; Line 391: } Line 392: Line 393: private static ArrayList<VmJob> getVmJobs(Guid vmId, Map<String, Object> xmlRpcStruct) { Why use an ArrayList and not a List? Line 394: if (!xmlRpcStruct.containsKey(VdsProperties.vmJobs)) { Line 395: return null; Line 396: } Line 397: ArrayList<VmJob> vmJobs = new ArrayList<VmJob>(); http://gerrit.ovirt.org/#/c/26905/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmJobInfoReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmJobInfoReturnForXmlRpc.java: Line 5: import org.ovirt.engine.core.vdsbroker.irsbroker.StatusReturnForXmlRpc; Line 6: Line 7: public final class VmJobInfoReturnForXmlRpc extends StatusReturnForXmlRpc { Line 8: private static final String VMJOB = "vmjob"; Line 9: public Map<String, Object> job; should be private, with a getter and a setter - it currently breaks FindBugs. Line 10: Line 11: @SuppressWarnings("unchecked") Line 12: public VmJobInfoReturnForXmlRpc(Map<String, Object> innerMap) { Line 13: super(innerMap); -- To view, visit http://gerrit.ovirt.org/26905 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d0ab4372fe98f8d61f4f393e2823d278f33621f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
