Allon Mureinik has posted comments on this change. Change subject: [WIP] webadmin: Enable Delete Snapshot while VM is running ......................................................................
Patch Set 5: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26910/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 382: } Line 383: Line 384: public static boolean isLiveMergeSupported(VM vm) { Line 385: return (vm != null && (Boolean) getConfigValuePreConverted( Line 386: ConfigurationValues.LiveMergeSupported, shouldn't this logic be checked in the CDA too? Line 387: vm.getVdsGroupCompatibilityVersion().toString())); Line 388: } Line 389: Line 390: public static void initNicHotplugSupportMap() { -- To view, visit http://gerrit.ovirt.org/26910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5162b0bf83ab447a427b5376b7a0980acb7ef213 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
