Ravi Nori has posted comments on this change. Change subject: [WIP] vdsbroker: introduce MergeVDSCommand ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26907/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MergeVDSCommandParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MergeVDSCommandParameters.java: Line 14: private Guid topImageId; Line 15: private long bandwidth; Line 16: Line 17: private MergeVDSCommandParameters() {} Line 18: Please add setters for the parameters. I think Json deserialization will have issues if they are not present Line 19: public MergeVDSCommandParameters( Line 20: Guid vdsId, Line 21: Guid vmId, Line 22: Guid storagePoolId, -- To view, visit http://gerrit.ovirt.org/26907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I320d1ac7de50f4a24236c6d26af75a3483b8bc5e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
