Allon Mureinik has posted comments on this change. Change subject: [WIP] core, db: add vm_jobs table, DAO, and VDS object ......................................................................
Patch Set 5: (5 comments) Missing - tests for the DAOs. Also some minor comments inline. http://gerrit.ovirt.org/#/c/26904/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBlockJob.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBlockJob.java: Line 13: private Long cursorEnd; Line 14: private Guid imageGroupId; Line 15: Line 16: public VmBlockJob() { Line 17: super(); Probably redundant. Line 18: super.setJobType(VmJobType.BLOCK); Line 19: blockJobType = VmBlockJobType.UNKNOWN; Line 20: bandwidth = cursorCur = cursorEnd = 0L; Line 21: imageGroupId = Guid.Empty; Line 16: public VmBlockJob() { Line 17: super(); Line 18: super.setJobType(VmJobType.BLOCK); Line 19: blockJobType = VmBlockJobType.UNKNOWN; Line 20: bandwidth = cursorCur = cursorEnd = 0L; oVirt's style frowns on such initializations. Please break it up to separate rows. Line 21: imageGroupId = Guid.Empty; Line 22: } Line 23: Line 24: public VmBlockJobType getBlockJobType() { http://gerrit.ovirt.org/#/c/26904/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBlockJobType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBlockJobType.java: Line 8: COPY(2), Line 9: COMMIT(3); Line 10: Line 11: private final int blockJobType; Line 12: private static final java.util.HashMap<Integer, VmBlockJobType> mappings = please remove the FQCN Line 13: new HashMap<Integer, VmBlockJobType>(); Line 14: Line 15: static { Line 16: for (VmBlockJobType component : values()) { http://gerrit.ovirt.org/#/c/26904/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmJobState.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmJobState.java: Line 6: UNKNOWN(0), Line 7: NORMAL(1); Line 8: Line 9: private final int jobState; Line 10: private static final java.util.HashMap<Integer, VmJobState> mappings = please remove the FQCN Line 11: new HashMap<Integer, VmJobState>(); Line 12: Line 13: static { Line 14: for (VmJobState component : values()) { http://gerrit.ovirt.org/#/c/26904/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmJobType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmJobType.java: Line 6: UNKNOWN(0), Line 7: BLOCK(1); Line 8: Line 9: private final int jobType; Line 10: private static final java.util.HashMap<Integer, VmJobType> mappings = please remove the FQCN Line 11: new HashMap<Integer, VmJobType>(); Line 12: Line 13: static { Line 14: for (VmJobType component : values()) { -- To view, visit http://gerrit.ovirt.org/26904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07734d4c4026062db7a505c1212553abf0b203ac Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
