Allon Mureinik has posted comments on this change. Change subject: core:Force remove should not delete VMs/Tempaltes with MSD. ......................................................................
Patch Set 3: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/28537/3//COMMIT_MSG Commit Message: Line 13: Today, when using force reomve on Storage Domain, we also remove VMs/Templates with disks on multiple storage domains, Line 14: those disks on the other data storage domains are left as floating disks in the system, Line 15: even though they might contain snapshots of the deleted VM/Template. Line 16: Line 17: This patch fix this behaviour by leaving the VMs/Templates with disks on MSD, when using force remove. please keep your lines no longer than 70 chars Line 18: It also deletes the devices which are related to those VMs/Templates, Line 19: since until now those devices were deleted also with the VM/Template. Line 20: Line 21: Change-Id: Ic222ee55a711ea9101bf20ac812219714f70aab3 Line 16: Line 17: This patch fix this behaviour by leaving the VMs/Templates with disks on MSD, when using force remove. Line 18: It also deletes the devices which are related to those VMs/Templates, Line 19: since until now those devices were deleted also with the VM/Template. Line 20: Missing: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1108242 Line 21: Change-Id: Ic222ee55a711ea9101bf20ac812219714f70aab3 -- To view, visit http://gerrit.ovirt.org/28537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic222ee55a711ea9101bf20ac812219714f70aab3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
