Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Private engine db credentials consts ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28646/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/database.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/database.py: Line 105 Line 106 Line 107 Line 108 Line 109 > this should use the patch that prompts for information at database.py, no? there is no difference between getting the jdbc url and it can go into common as well to avoid the duplicate logic. input is dbenv output is jdbc url -- To view, visit http://gerrit.ovirt.org/28646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18e59fcd518cac357a208e6e7f501cea5a528c38 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
