Allon Mureinik has posted comments on this change. Change subject: [WIP] vdsbroker: update vmJobs when updating vm statistics ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26906/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 361: getDbFacade().getVmJobDao().removeAll(vmJobIdsToRemove); Line 362: return null; Line 363: } Line 364: }); Line 365: } > Yes, I'd think so. This is what saveVmDevicesToDb did, and I haven't inves Lets leave it for now - if this is how the class is built, let's follow suite. If we ever want to fix this, it should be done throughout the class. Line 366: } Line 367: Line 368: /** Line 369: * check if value is less than configurable threshold , if yes , generated event log message -- To view, visit http://gerrit.ovirt.org/26906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1a300d440a0a93381afe047eb294106a38088ec Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
