anmolbabu has posted comments on this change. Change subject: restApi : RestApi to export volume profile to pdf ......................................................................
Patch Set 17: (2 comments) http://gerrit.ovirt.org/#/c/28340/17/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 4420: signatures: [] Line 4421: urlparams: Line 4422: nfsStatistics: {context: matrix, type: 'xs:boolean', value: true|false, required: false} Line 4423: headers: Line 4424: Content-Type: {value: application/pdf, required: true} > This isn't required, as there shouldn't be two URLs for the same resource. Done Line 4425: - name: /clusters/{cluster:id}/glustervolumes/{glustervolume:id}/bricks|rel=add Line 4426: description: add a new brick to the gluster volume attached to the cluster Line 4427: request: Line 4428: body: http://gerrit.ovirt.org/#/c/28340/17/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java: Line 188: throw new WebFaultException(null, localize(Messages.BACKEND_FAILED), Response.Status.INTERNAL_SERVER_ERROR); Line 189: } Line 190: } Line 191: Line 192: public Response getGlusterVolumeProfileAsPdf() { > MIssing the @Override annotation. Done Line 193: boolean nfsStats = isNfsStatistics(); Line 194: VdcQueryReturnValue result = runQuery(VdcQueryType.GetGlusterVolumeProfileInfo, new GlusterVolumeProfileParameters(Guid.createGuidFromString(parent.getParent().get().getId()), guid, nfsStats)); Line 195: if (result != null && result.getSucceeded() && result.getReturnValue() != null) { Line 196: GlusterVolumeProfileInfo profileInfo = (GlusterVolumeProfileInfo) result.getReturnValue(); -- To view, visit http://gerrit.ovirt.org/28340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3ff28f5cf18bd7a2bcb53a169873fe6ae3541ed Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
