Juan Hernandez has posted comments on this change. Change subject: restapi: add QoS RESTful interface for storage QoS ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/27097/7/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java: Line 8: import org.ovirt.engine.core.common.businessentities.qos.StorageQos; Line 9: Line 10: public class QosMapper { Line 11: Line 12: private final static int UNLIMITED = -1; Can you use the IntegerMapper.mapNullToMinusOne() method instead of this constant? Line 13: Line 14: @Mapping(from = QosBase.class, to = QoS.class) Line 15: public static QoS map(QosBase entity, QoS template) { Line 16: QoS model = template != null ? template : new QoS(); -- To view, visit http://gerrit.ovirt.org/27097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b50554531522802f19046c0051d82f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
