Roy Golan has posted comments on this change.
Change subject: core: refactor UpdateVmCommand
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 64: VmStatic newVmStatic = getParameters().getVmStaticData();
you dropped the null check for newVMData and oldVmData and we potantialy hava
an NPE here
maybe your checking this in another place where I don't see it? (canDoAction?)
BTW you can put @NotNull on the paramter class and avoid the null check here if
you want
Line 167: if (StringUtils.isEmpty(vmFromParams.getvm_name())) {
we're deprecating StringUtils. use org.apache.commons.lang.StringUtils.isEmpty
instead
Line 173: boolean vmNameValidLength = isVmNameValidLength(vmFromParams);
no need for that check since the Validation Framework does this already
Line 272: {
formating?
--
To view, visit http://gerrit.ovirt.org/5454
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2052e1d367bb00e7cf8dc2f44fe85938d8bdd336
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
