Greg Padgett has posted comments on this change. Change subject: [WIP] core: introduce RemoveSnapshotSingleDiskLive BLL command ......................................................................
Patch Set 5: FYI, note about this patch: The logic is driven by RemoveSnapshotSingleDiskLiveCommand.proceedCommandExecution(), which steps through the child commands needed for Live merge: 1. MergeCommand - to run the MergeVDSCommand NG-async-task. 2. MergeStatusCommand - to get the volume chain, determine the merge type, and determine if the merge was successful. 3. DestroyImageCommand - to remove the now-orphaned volume once merge is complete. As of now, there are still some details to work out such as checking the command execution messages, ensuring that RemoveSnapshotCommand properly calls and waits for its children spawned by CommandExecutor, and some general cleanup. That being said, the general method and use of the new framework is ready for review and comments are more than welcome. Thanks in advance! -- To view, visit http://gerrit.ovirt.org/26909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47eb91a0ea1fe150e3b2152e2c9d5f1f2eb3678 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
