Alon Bar-Lev has posted comments on this change. Change subject: aaa: Adding capabilities to Authz ......................................................................
Patch Set 3: (2 comments) I thought we have single patch :) not that important. http://gerrit.ovirt.org/#/c/28601/3/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Authz.java: Line 37: Line 38: /** Line 39: * Capabilities. Line 40: */ Line 41: public static class Capabilities { please move down after InvokeCommands, if you notice we have consistent ordering :) Line 42: /** Line 43: * Recursive groups resolving is always performed by provider. Line 44: * No need to pass the {@link QueryFlags#RESOLVE_GROUPS_RECURSIVE} flag when Line 45: * performing groups fetching. Line 41: public static class Capabilities { Line 42: /** Line 43: * Recursive groups resolving is always performed by provider. Line 44: * No need to pass the {@link QueryFlags#RESOLVE_GROUPS_RECURSIVE} flag when Line 45: * performing groups fetching. I would suggest: Provider resolves groups recursively. This implies provider ignores {@link QueryFlags#RESOLVE_GROUPS_RECURSIVE} flag. Line 46: */ Line 47: public static final long RECURSIVE_GROUPS_RESOLVING = (1 << 0); Line 48: } Line 49: -- To view, visit http://gerrit.ovirt.org/28601 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f2f76e04e8e48b2e151a8d80b5407ad996438ca Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
