Omer Frenkel has posted comments on this change. Change subject: core: Support creation of Vms with 4000GB of memory ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28590/1/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 622: select fn_db_add_config_value('VM64BitMaxMemorySizeInMB','524288','3.0'); Line 623: select fn_db_add_config_value('VM64BitMaxMemorySizeInMB','2097152','3.1'); Line 624: select fn_db_add_config_value('VM64BitMaxMemorySizeInMB','2097152','3.2'); Line 625: select fn_db_add_config_value('VM64BitMaxMemorySizeInMB','2097152','3.3'); Line 626: select fn_db_add_config_value('VM64BitMaxMemorySizeInMB','2097152','3.4'); should be also for 3.4 this means that need also to handle upgrade config (see upgrade part below in this file) Line 627: select fn_db_add_config_value('VM64BitMaxMemorySizeInMB','4096000','3.5'); Line 628: select fn_db_add_config_value('VmGracefulShutdownMessage','System Administrator has initiated shutdown of this Virtual Machine. Virtual Machine is shutting down.','general'); Line 629: select fn_db_add_config_value('VmGracefulShutdownTimeout','30','general'); Line 630: select fn_db_add_config_value('VMMinMemorySizeInMB','256','general'); -- To view, visit http://gerrit.ovirt.org/28590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I13a40b21db18e98c02d11fe7ff158a299cd7bc1c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
