Alon Bar-Lev has posted comments on this change. Change subject: core: a bit nicer debug info on buildSequence ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28556/1/src/otopi/context.py File src/otopi/context.py: Line 339: l[candidateindex]['method'], Line 340: candidateindex, Line 341: what, Line 342: metadata[what], Line 343: ) > maybe using format here will help the readability. I agree. also, please keep modifying location as prefix. however having multiple lines will create so long output that the terminal buffer probably fillup... do we really need so much text? for example: method: {method}{index}->{method}{index} Line 344: ) Line 345: l.insert(candidateindex + offset, metadata) Line 346: if candidateindex < index: Line 347: del l[index + 1] -- To view, visit http://gerrit.ovirt.org/28556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37f2d2b770c245d4bfc28313304103710bef0ca4 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
