Liran Zelkha has posted comments on this change. Change subject: core: long query response time while many simultaneously queries are running ......................................................................
Patch Set 15: (2 comments) http://gerrit.ovirt.org/#/c/27586/15/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java: Line 86: }; Line 87: } Line 88: Line 89: @Override Line 90: public void updateAllWithoutImageId(Collection<DiskImageDynamic> diskImageDynamic) { > please add a dao test for new function Done Line 91: updateAllInBatch("Updatedisk_image_dynamic_by_disk_id", diskImageDynamic, getBatchMapper()); Line 92: } http://gerrit.ovirt.org/#/c/27586/15/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 187: } Line 188: Line 189: getDbFacade().getVmNetworkStatisticsDao().updateAllInBatch(allVmInterfaceStatistics); Line 190: Line 191: getDbFacade().getDiskImageDynamicDao().updateAllWithoutImageId(_vmDiskImageDynamicToSave); > sorry for not noticing before, but i'd rename to clearer name (updateDiskIm Done Line 192: getDbFacade().getLunDao().updateAllInBatch(vmLunDisksToSave); Line 193: saveVmDevicesToDb(); Line 194: saveVmGuestAgentNetworkDevices(); Line 195: getVdsEventListener().addExternallyManagedVms(_externalVmsToAdd); -- To view, visit http://gerrit.ovirt.org/27586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94e20d782bc4e2befaf4338f51551a2855509769 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
