Martin Peřina has posted comments on this change.

Change subject: core: start PM enabled hosts after engine restart
......................................................................


Patch Set 2:

(2 comments)

So I will create new patch based on this one, which will change status to 
Connecting for all hosts in status Kdumping

http://gerrit.ovirt.org/#/c/28305/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java:

Line 41: @DependsOn({ "Backend"})
Line 42: public class InitBackendServicesOnStartupBean implements 
InitBackendServicesOnStartup{
Line 43: 
Line 44:     private static final Logger log = 
LoggerFactory.getLogger(InitBackendServicesOnStartupBean.class);
Line 45:     private List<VDS> hosts;
This could be a method attribute only ...
Line 46: 
Line 47:      /**
Line 48:      * This method is called upon the bean creation as part
Line 49:      * of the management Service bean life cycle.


Line 53:     public void create() {
Line 54: 
Line 55:         try {
Line 56:             // This must be done before starting to sample the hosts 
status from VDSM since the sampling will turn such host from Reboot to 
NonResponsive
Line 57:             hosts = DbFacade.getInstance().getVdsDao().getAll();
So why not call PmHealtCheckManager.recover() here?
Line 58: 
Line 59:             // Create authentication profiles for all the domains that 
exist in the database:
Line 60:             // TODO: remove this later, and rely only on the custom 
and built in extensions directories configuration
Line 61: 


-- 
To view, visit http://gerrit.ovirt.org/28305
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbfe83535364556df72eaac348e58d4b7146156e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to