Yair Zaslavsky has posted comments on this change.

Change subject: core: Deprecate & delete some classes in compat
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File 
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Regex.java
Line 10:  */
I would consult here with Asaf. They added a Regex support to GWT, and I think 
they conform against compat.

....................................................
File 
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/RegexOptions.java
Line 9: public class RegexOptions {
Same as before, let's consult with Asaf.

--
To view, visit http://gerrit.ovirt.org/5471
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad81967bec1ba9bc5ff3de1abbf39093db67e51
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to