Liron Aravot has posted comments on this change. Change subject: core: remove uneeded logging from StorageHelperDirector ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperDirector.java Line 41: if (storageType != StorageType.ALL && storageType != StorageType.UNKNOWN) if we have N values in the StoradgeType enum - it means that we will perform 2*N-4 additional comparisons when only two of the values won't be found, if we will have 2 more values that doesn't have concrete class it will escalate two 4*N-8 and so on. it might be better to skip the additional comparisons and 'absorb' the two exceptions - as the number of two CNFE exceptions is a permanent value(2) and the number of comparisons is not (as it's dependent in N) - but if you prefer it that way I'll change it. -- To view, visit http://gerrit.ovirt.org/5451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd95ba8f9c3c3ad80b8cfda70fd62d2bdf4b712e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
