Ravi Nori has posted comments on this change.

Change subject: engine: Introduction of command entity dao
......................................................................


Patch Set 31:

The logic for root command id has not changed from 3.4

Get Parent parameters using

public VdcActionParametersBase getParentParameters(VdcActionType parentCommand) 
{
VdcActionParametersBase parentParameters = getParametersForTask(parentCommand, 
getParameters());
if (parentParameters.getParametersCurrentUser() == null && getCurrentUser() != 
null) {
parentParameters.setParametersCurrentUser(getCurrentUser());
}
return parentParameters;
}

and then getCommandId() from the above returned value.

In the latest patches I have dropped parent command id, it is not needed

-- 
To view, visit http://gerrit.ovirt.org/26337
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463102d85de7558fbcab23585ad6b48cdc35c0a0
Gerrit-PatchSet: 31
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to