Alona Kaplan has posted comments on this change. Change subject: userportal,webadmin:change Translator to interface ......................................................................
Patch Set 3: (4 comments) Nice! Just few small comments. http://gerrit.ovirt.org/#/c/26596/3/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/EnumTranslator.java: Line 27: RuntimeException Why do you add the RuntimeException() parameter? Line 41: return notLocalizedKey(key, null); Line 42: } Line 43: Line 44: private String notLocalizedKey(Enum<?> key, MissingResourceException e) { Line 45: String logString = "Missing Enum resource '" + key + "'."; //$NON-NLS-1$ redundant spaces before the NLS comment. Line 46: if (e != null) { Line 47: logString += e.getLocalizedMessage(); Line 48: } Line 49: Line 47: logString logString += " " + e.getLocalizedMessage(); Line 47: logString += e.getLocalizedMessage(); Line 48: } Line 49: Line 50: logger.info(logString); Line 51: return key.name(); Please run formatter on this method. Line 52: } Line 53: Line 54: private String keyToTranslate(Enum<?> key) { Line 55: String className = key.getDeclaringClass().toString(); -- To view, visit http://gerrit.ovirt.org/26596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib018c1faf0c2e1ebaa81217d5e3696d9c8de20cf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
