Frank Kobzik has posted comments on this change. Change subject: core: Allow Template sorting according to missing fields ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28371/2/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java: Line 73: columnNameDict.put(QUOTA, "quota_name"); Line 74: columnNameDict.put(VMT_ID, "vmt_guid"); Line 75: columnNameDict.put(DESCRIPTION, "description"); Line 76: columnNameDict.put(ARCHITECTURE, "architecture"); Line 77: columnNameDict.put(VERSION_NAME_AND_NUMBER, "template_version_name, template_version_number"); > Guys, I'd like to know your opinion about this. This allows us to sort resu do you think it would be sufficient to order by template name only? Line 78: Line 79: notFreeTextSearchableFieldsList.add(OS); Line 80: // Building the validation dict Line 81: buildBasicValidationTable(); -- To view, visit http://gerrit.ovirt.org/28371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02fdb98b6d7eea5e7379fb1d19ee9625402caf72 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
