Liran Zelkha has posted comments on this change. Change subject: core: long query response time while many simultaneously queries are running ......................................................................
Patch Set 12: -Verified (3 comments) http://gerrit.ovirt.org/#/c/27586/12/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java: Line 108: Line 109: @Test Line 110: public void testGetImageGroupIdMapForImageList() { Line 111: Guid IMAGE_GROUP_ID = Guid.createGuidFromString("1b26a52b-b60f-44cb-9f46-3ef333b04a35"); Line 112: Guid IMAGE_ID_TO_GROUP = Guid.createGuidFromString("c9a559d9-8666-40d1-9967-759502b19f0d"); > when you rebase if you could change the names to java standard it'll be gre Done Line 113: Line 114: Map<Guid, Guid> ids = dbFacade.getImageDao() Line 115: .getImageGroupIdMapForImageList(new HashSet<>(Arrays.asList(IMAGE_GROUP_ID))); Line 116: assertEquals(IMAGE_ID_TO_GROUP, ids.get(IMAGE_GROUP_ID)); http://gerrit.ovirt.org/#/c/27586/12/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 1717: // compare between vm in cache and vm from vdsm Line 1718: removeVmsFromCache(staleRunningVms); Line 1719: } Line 1720: Line 1721: private Map<Guid, Guid> loadImageGroupsIdsIfNeeded() { > I still think that the better approach is to change the stored procedure in Done Line 1722: if (_vdsManager.getRefreshStatistics()) { Line 1723: Set<Guid> requiredDisks = new HashSet<>(); Line 1724: for (VmInternalData vmInternalData : _runningVms.values()) { Line 1725: for (DiskImageDynamic disk : vmInternalData.getVmDynamic().getDisks()) { Line 1979: vmToUpdate.updateRunTimeStatisticsData(vmStatistics, vmToUpdate); Line 1980: addVmStatisticsToList(vmToUpdate.getStatisticsData()); Line 1981: updateInterfaceStatistics(vmToUpdate, vmStatistics); Line 1982: Line 1983: try { > see related comment in patch #10, why is this try-catch block is needed as Done Line 1984: for (DiskImageDynamic imageDynamic : _runningVms.get(vmToUpdate.getId()).getVmDynamic().getDisks()) { Line 1985: Guid activeImageId = diskImages.get(imageDynamic.getId()); Line 1986: // We have disk_id statistics, which is good, but disk_image_dynamic table contains image_id, so we Line 1987: // update for the AI. -- To view, visit http://gerrit.ovirt.org/27586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94e20d782bc4e2befaf4338f51551a2855509769 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
