Vojtech Szocs has posted comments on this change. Change subject: webadmin: KeyValueModel to reuse CustomPropertiesUtils code ......................................................................
Patch Set 9: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/27387/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/CustomPropertiesUtils.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/customprop/CustomPropertiesUtils.java: Line 292: * if specified properties has syntax errors Line 293: * @return map containing all valid custom properties ({@code LinkedHashMap} is used to ensure properties order is Line 294: * constant) Line 295: */ Line 296: public Map<String, String> convertProperties(String properties, Map<String, String> regExMap) { Nice Javadoc, it helps me understand the contract of this method. Line 297: Map<String, String> map = new LinkedHashMap<String, String>(); Line 298: if (!StringHelper.isNullOrEmpty(properties)) { Line 299: String keyValuePairs[] = properties.split(PROPERTIES_DELIMETER); Line 300: for (String keyValuePairStr : keyValuePairs) { http://gerrit.ovirt.org/#/c/27387/9/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java: Line 12: import org.ovirt.engine.ui.uicompat.ConstantsManager; Line 13: Line 14: public class KeyValueModel extends BaseKeyModel { Line 15: Line 16: private static CustomPropertiesUtils customPropertiesUtils = SimpleCustomPropertiesUtil.getInstance(); Can we make this field final? Line 17: private String saveEntity; Line 18: Line 19: public KeyValueModel() { Line 20: super(ConstantsManager.getInstance().getConstants().pleaseSelectKey(), ConstantsManager.getInstance() -- To view, visit http://gerrit.ovirt.org/27387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5294f8d14149bff14f26a68d13b522a4cc4e97f2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
