Sahina Bose has posted comments on this change. Change subject: engine : Introduce base class for nfs and brick profile ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/28485/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BrickProfileDetails.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BrickProfileDetails.java: Line 24: public boolean equals(Object obj) { Line 25: if (obj == null) { Line 26: return false; Line 27: } Line 28: super.equals(obj); you're not using the return value shouldn't it be... if (!super.equals(obj)) { return false } Line 29: BrickProfileDetails brickDetails = (BrickProfileDetails) obj; Line 30: if (brickDetails.getBrickId() == null) { Line 31: return false; Line 32: } -- To view, visit http://gerrit.ovirt.org/28485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib78fa33cd268097adf8e442e653bb0f1454be4d5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
