Vojtech Szocs has posted comments on this change. Change subject: userportal: extended event sub tab loading ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28035/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/DataBoundTabModelProvider.java: Line 63: }); Line 64: getModel().getPropertyChangedEvent().addListener(new IEventListener() { Line 65: @Override Line 66: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 67: if (args instanceof PropertyChangedEventArgs) { > Well findbugs complains which we can surpress with the xml file, then cover Yes, Coverity Scan also complains, however it doesn't take our FindBugs suppression XML config into account (and it should, at least in my opinion), so I wouldn't worry too much about that. In other words, this warning is not very relevant because we know it will always be PropertyChangedEventArgs in runtime, we should fix the code to eliminate this warning - however not in user code (multiple places), but in infra code (single place, affecting all user code). We should take the approach that is more efficient. Line 68: PropertyChangedEventArgs pcArgs = (PropertyChangedEventArgs) args; Line 69: if (PropertyChangedEventArgs.Args.PROGRESS.toString().equals(pcArgs.propertyName)) { Line 70: clearData(); Line 71: } -- To view, visit http://gerrit.ovirt.org/28035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81495d93c0fb9a7989ff2147d6bfcbd8d769d6ff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
