anmolbabu has posted comments on this change. Change subject: webadmin : Gluster Volume Profile ......................................................................
Patch Set 44: (4 comments) http://gerrit.ovirt.org/#/c/27470/44/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeProfileStatisticsModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeProfileStatisticsModel.java: Line 245: Line 246: public void showNfsProfileStats(GlusterVolumeProfileInfo entity) { Line 247: List<GlusterVolumeProfileStats> nfsProfileDetails = entity.getNfsProfileDetails(); Line 248: getNfsServers().setItems(nfsProfileDetails); Line 249: getNfsServers().setSelectedItem(nfsProfileDetails.get(0)); > you may want to check the size of the list Done Line 250: } Line 251: Line 252: private String formatRunTime(UIMessages messages, Pair<Integer, String> runTimeConverted, Pair<Integer, String> intervalRunTimeConverted) { Line 253: return messages.glusterVolumeCurrentProfileRunTime(intervalRunTimeConverted.getFirst(), intervalRunTimeConverted.getSecond(), runTimeConverted.getFirst(), runTimeConverted.getSecond()); http://gerrit.ovirt.org/#/c/27470/44/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Line 777: profileStatsModel.queryBackend(true); Line 778: } Line 779: Line 780: public void setProfileWindow(VolumeProfileStatisticsModel profileStatsModel) { Line 781: if(getWindow() == null) { > What if getWindow() is not null Done Line 782: setWindow(profileStatsModel); Line 783: setHelpTag(HelpTag.volume_profile_statistics); Line 784: setHashName("volume_profile_statistics"); //$NON-NLS-1$ Line 785: } Line 781: if(getWindow() == null) { Line 782: setWindow(profileStatsModel); Line 783: setHelpTag(HelpTag.volume_profile_statistics); Line 784: setHashName("volume_profile_statistics"); //$NON-NLS-1$ Line 785: } > This section can be moved to the above method itself. Done Line 786: } Line 787: Line 788: private void cancelRebalanceStatus() { Line 789: if (getWindow() == null) http://gerrit.ovirt.org/#/c/27470/44/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java: Line 63: } Line 64: else if (lastExecutedCommand == getModel().getStatusRebalanceCommand() || lastExecutedCommand.getName().equals("onStopRebalance")) {//$NON-NLS-1$ Line 65: return rebalanceStatusPopupProvider.get(); Line 66: } Line 67: else if(lastExecutedCommand == getModel().getShowVolumeProfileDetailsCommand() || lastExecutedCommand.getName().equals("Show Profile Details")) {//$NON-NLS-1$ > use CamelCase Done Line 68: return volumeProfileStatsPopupProvider.get(); Line 69: } Line 70: else { Line 71: return super.getModelPopup(source, lastExecutedCommand, windowModel); -- To view, visit http://gerrit.ovirt.org/27470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic305a0fece18f29d24a9d0324391e484681fa033 Gerrit-PatchSet: 44 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
