Vojtech Szocs has posted comments on this change.

Change subject: Introduction of filters to unify AAA flows for UI and REST-API
......................................................................


Patch Set 58:

Guys, I've just verified the latest patchset (58), trying to simulate requests 
to REST API from a web application (using RESTClient Firefox add-on):

1, acquire session
* request contains Authorization + Prefer header
* response contains JSESSIONID header + Set-Cookie header for JSESSIONID cookie

2, reuse session
* request contains Authorization + Prefer header along with Cookie header 
(included automatically by browser)
* response contains JSESSIONID header -- Great! This wasn't the case before, 
now it's more consistent.

So this patch works as expected.

In fact, it improves the usability from web application perspective, because 
JSESSIONID response _header_ is now consistently included in both "acquire 
session" and "reuse session" HTTP responses.

-- 
To view, visit http://gerrit.ovirt.org/28022
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073
Gerrit-PatchSet: 58
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to