Gilad Chaplik has posted comments on this change. Change subject: core: support NUMA in oVirt Scheduler ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28467/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/MemoryPolicyUnit.java: Line 52: // [and] Line 53: // * host support NUMA configuration Line 54: // * there isn't enough memory for pinned vNode in pNode Line 55: if (isVmNumaPinned(vmNumaNodes) && vm.getNumaTuneMode() == NumaTuneMode.STRICT Line 56: && (!vds.isNumaSupport() || !canVmNumaPinnedToVds(vm, vmNumaNodes, vds))) { > Are you sure the condition is correct? The last and part the comment has a mistake... /s/* host support /* host doesn't support / basically we see if we have numa pinning for the VM and in strict mode (easy part). if so, we filter the host in the following condition: * the host doesn't support NUMA (no pinning allowed). * the pinning isn't possible. answer your question? will update the patch with a better comment and try to do sth about an easier to read if condition. Line 57: log.debugFormat("host '{0}' cannot accommodate memory of VM's pinned virtual NUMA nodes within host's physical NUMA nodes", Line 58: vds.getName()); Line 59: messages.addMessage(vds.getId(), VdcBllMessages.VAR__DETAIL__NOT_ENOUGH_MEMORY.toString()); Line 60: continue; -- To view, visit http://gerrit.ovirt.org/28467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b41e5ac9d633953dec7bfab5621ace8bb1b13cd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Chuan Liao <chuan.l...@hp.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
