Alon Bar-Lev has posted comments on this change. Change subject: kdump: Add kdump plugin ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/28385/4/src/plugins/ovirt-host-deploy/core/offlinepackager.py File src/plugins/ovirt-host-deploy/core/offlinepackager.py: Line 76: Line 77: pkgs = [] Line 78: if ( Line 79: name in ('redhat', 'centos') and Line 80: version.split('.')[0] == '6' or > I don't need (), and operator has a precedence over or operator. I looked a well, for the sake of these poor guys who cannot read expression... (xxxx and xxx) or (yyyy and yyy) please Line 81: name == 'fedora' and Line 82: version == '20' Line 83: ): Line 84: pkgs = [ http://gerrit.ovirt.org/#/c/28385/4/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 141: stage=plugin.Stages.STAGE_INIT, Line 142: ) Line 143: def _setup(self): Line 144: self.environment[odeploycons.KdumpEnv.ENABLE] = False Line 145: self.environment[odeploycons.KdumpEnv.SUPPORTED] = False > I don't understand. So should this be set using setdefault? I would have put both as set default, although not that important. Line 146: Line 147: @plugin.event( Line 148: stage=plugin.Stages.STAGE_CUSTOMIZATION, Line 149: priority=plugin.Stages.PRIORITY_HIGH, -- To view, visit http://gerrit.ovirt.org/28385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idda48cb053c7e8747de5434c3681403f739c06b1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
