Alon Bar-Lev has posted comments on this change. Change subject: Introduction of filters to unify AAA flows for UI and REST-API ......................................................................
Patch Set 56: (4 comments) next time please cherry-pick! http://gerrit.ovirt.org/#/c/28022/56/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/FiltersHelper.java: Line 14: public static class Constants { Line 15: public static final String REQUEST_AUTH_RECORD_KEY = "ovirt_aaa_auth_record"; Line 16: public static final String REQUEST_SCHEMES_KEY = "ovirt_aaa_schemes"; Line 17: public static final String REQUEST_PROFILE_KEY = "ovirt_aaa_profile"; Line 18: public static final String REQUEST_ASYNC_KEY = "ovirt_aaa_restapi_async"; remove Line 19: public static final String HEADER_AUTHORIZATION = "Authorization"; Line 20: public static final String HEADER_WWW_AUTHENTICATE = "WWW-Authenticate"; Line 21: public static final String HEADER_PREFER = "Prefer"; Line 22: public static final String HEADER_JSESSIONID_COOKIE = "JSESSIONID"; http://gerrit.ovirt.org/#/c/28022/56/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/SessionUtils.java File backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/SessionUtils.java: remove Line 1: package org.ovirt.engine.api.common.security.auth; Line 2: Line 3: import javax.security.jacc.PolicyContextException; Line 4: import javax.servlet.http.HttpServletRequest; http://gerrit.ovirt.org/#/c/28022/56/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/SessionProcessor.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/SessionProcessor.java: Line 25: Line 26: @Provider Line 27: @ServerInterceptor Line 28: @Precedence("SECURITY") Line 29: public class SessionProcessor implements PostProcessInterceptor, PreProcessInterceptor { please reorder pre, post Line 30: Line 31: private Current current; Line 32: private SessionHelper sessionHelper; Line 33: private BackendLocal backend; Line 32: private SessionHelper sessionHelper; Line 33: private BackendLocal backend; Line 34: Line 35: @Override Line 36: public void postProcess(ServerResponse response) { post after pre please Line 37: if (current.get(MetaData.class).hasKey("async") && Line 38: Boolean.TRUE.equals((Boolean) current.get(MetaData.class).get("async"))) { Line 39: SessionUtils.getCurrentHttpServletRequest().setAttribute(SessionConstants.REQUEST_ASYNC_KEY, true); Line 40: } -- To view, visit http://gerrit.ovirt.org/28022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5536d123b6407acf41b6946dde796bd67d1e073 Gerrit-PatchSet: 56 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
