Maor Lipchuk has posted comments on this change. Change subject: core: making updateDate a member ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/28398/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-06-08 17:06:32 +0300 Line 6: Line 7: core: making updateDate a member Line 8: Line 9: chaing updateDate to be a class member to avoid passing it between the chaing? Line 10: different class methods. Line 11: Line 12: Change-Id: I33af57ada23ca81c469f0fc01932affb8298a69f Line 6: Line 7: core: making updateDate a member Line 8: Line 9: chaing updateDate to be a class member to avoid passing it between the Line 10: different class methods. What is the reason to make this member global? this might be confusing if developers will use it when it is not initialized Line 11: Line 12: Change-Id: I33af57ada23ca81c469f0fc01932affb8298a69f http://gerrit.ovirt.org/#/c/28398/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java: Line 117: Line 118: return postUpdateDescription; Line 119: } Line 120: Line 121: private String generateOvfStoreDescription(Date updateDate, boolean isUpdated, Long size) { Dont you want to remove updateDate also here Line 122: Map<String, Object> description = new HashMap<>(); Line 123: description.put(OvfInfoFileConstants.IsUpdated, isUpdated); Line 124: description.put(OvfInfoFileConstants.DiskDescription, OvfInfoFileConstants.OvfStoreDescriptionLabel); Line 125: description.put(OvfInfoFileConstants.LastUpdated, updateDate.toString()); -- To view, visit http://gerrit.ovirt.org/28398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33af57ada23ca81c469f0fc01932affb8298a69f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
