Eli Mesika has posted comments on this change. Change subject: webadmin: cluster sorting ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/28361/2/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ClusterConditionFieldAutoCompleter.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ClusterConditionFieldAutoCompleter.java: Line 9: public ClusterConditionFieldAutoCompleter() { Line 10: // Building the basic vervs Dict Line 11: mVerbs.add(NAME); Line 12: mVerbs.add(DESCRIPTION); Line 13: mVerbs.add("COMMENT"); why not moving all to constants ? Line 14: mVerbs.add("ARCHITECTURE"); Line 15: Line 16: // Building the autoCompletion Dict Line 17: buildCompletions(); http://gerrit.ovirt.org/#/c/28361/2/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java: Line 244: new ClusterConditionFieldAutoCompleter(), Line 245: "vds_groups_view", Line 246: "vds_groups_storage_domain", Line 247: "vds_group_id", Line 248: "name ASC")); does this really matter ? Line 249: put(SearchObjects.QUOTA_OBJ_NAME, new EntitySearchInfo(new QuotaConditionFieldAutoCompleter(), Line 250: new QuotaConditionFieldAutoCompleter(), Line 251: "quota_view", Line 252: "quota_view", -- To view, visit http://gerrit.ovirt.org/28361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7b2d9938a7e9b7e32238a284c0ddca6568b3bdc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
