Tal Nisan has posted comments on this change.

Change subject: core: Added a method to add a CDA message variable
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/27224/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java:

Line 1923:      * @param varName the variable name
Line 1924:      * @param varValue the variable value
Line 1925:      */
Line 1926:     protected void addCanDoActionMessageVariable(String varName, 
Object varValue) {
Line 1927:         String message = String.format("$%s %s", varName, varValue);
> feel free to inline this.
Done
Line 1928:         getReturnValue().getCanDoActionMessages().add(message);
Line 1929:     }
Line 1930: 
Line 1931:     /**


-- 
To view, visit http://gerrit.ovirt.org/27224
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife678c48bd4ca2422a5ef9c09566c34936edc9df
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to