Shubhendu Tripathi has posted comments on this change. Change subject: engine : volume profile export to pdf command ......................................................................
Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/28000/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeProfilePdfExportCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeProfilePdfExportCommand.java: Line 116: e.printStackTrace(); Line 117: } Line 118: } Line 119: Line 120: private void exportNfsProfileDetails(Document document, List<NfsProfileDetails> nfsProfiles) > Both of them are operating on 2 completely different datatype/entities.Or M Yes that could be good idea. Line 121: throws BadElementException { Line 122: Anchor nfsProfileAnchor = new Anchor("Nfs Profile Details"); Line 123: nfsProfileAnchor.setName("Nfs Profile Details"); Line 124: Chapter nfsProfileDetails = new Chapter(new Paragraph(nfsProfileAnchor), 1); Line 167: private List<String> lineariseStats(StatsInfo statsInfo) { Line 168: return stringifyAndLineariseFopStats(statsInfo.getFopStats()); Line 169: } Line 170: Line 171: private List<String> stringifyAndLineariseFopStats(List<FopStats> fopsStats) { > Done.Any suggestions? May be as simple as getLinearStrings() Line 172: List<String> fopStatsStringified = new ArrayList<String>(); Line 173: for (FopStats fopStats : fopsStats) { Line 174: fopStatsStringified.add(fopStats.getName()); Line 175: fopStatsStringified.add(fopStats.getHits() + ""); -- To view, visit http://gerrit.ovirt.org/28000 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I208a77456487a5f735948d6cf9fec54f004b6e89 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
