Sandro Bonazzola has posted comments on this change. Change subject: try harder when starting vdsmd ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28432/1/ovirt_hosted_engine_ha/agent/hosted_engine.py File ovirt_hosted_engine_ha/agent/hosted_engine.py: Line 418: break Line 419: except Exception as _ex: Line 420: if tries > constants.MAX_VDSM_START_RETRIES: Line 421: self._log.error("Can't start vdsmd, the number of errors " Line 422: "has exceeded the limit: '{0}'".format(_ex)) fails pep8 here Line 423: raise Line 424: self._log.warn("Can't start vdsmd, waiting '{0}' seconds before" Line 425: " the next attempt" Line 426: .format(constants.MAX_VDSM_WAIT_SECS)) Line 420: if tries > constants.MAX_VDSM_START_RETRIES: Line 421: self._log.error("Can't start vdsmd, the number of errors " Line 422: "has exceeded the limit: '{0}'".format(_ex)) Line 423: raise Line 424: self._log.warn("Can't start vdsmd, waiting '{0}' seconds before" fails pep8 here Line 425: " the next attempt" Line 426: .format(constants.MAX_VDSM_WAIT_SECS)) Line 427: time.sleep(constants.MAX_VDSM_WAIT_SECS) Line 428: -- To view, visit http://gerrit.ovirt.org/28432 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I806437b8c5eafd32fb37d0b3f2f59995faa28cdc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
