Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: added IDs to locale boxes, welcome page links ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28333/1/backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp File backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp: Line 50: </div> Line 51: Line 52: <div style="clear: both;"></div> Line 53: <div class="col-sm-12 locale-div"> Line 54: <select class="gwt-ListBox obrand_locale_list_box" onchange="localeSelected(this)" id="OvirtEngineJSP_localeBox"> I'd suggest to just use "localeBox" here, just like other IDs in this JSP. (No need for prefix, as this is the actual JSP page and not some fragment/snippet of it.) Line 55: <c:forEach items="${requestScope['localeKeys']}" var="localeKey"> Line 56: <c:choose> Line 57: <c:when test="${requestScope['locale'].toString() == localeKey}"> Line 58: <c:set var="selectedLocale" value="${localeKey}"/> http://gerrit.ovirt.org/#/c/28333/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java: Line 107: } Line 108: Line 109: private void initLocalizationEditor() { Line 110: localeBox = new ListBox(); Line 111: localeBox.getElement().setId("AbstractLoginFormView_localeBox"); //$NON-NLS-1$ Instead of defining ID manually, please use @WithElementId annotation, for example: @UiField(provided = true) @Ignore @WithElementId public ListBox localeBox; The @WithElementId annotation is part of our declarative DOM element ID framework sometimes referred to as "IdHandler". Please see ElementIdHandler and ElementIdHandlerGenerator classes for details on how this framework works and how it's implemented. Line 112: Line 113: // Add the option to change the locale Line 114: String currentLocale = LocaleInfo.getCurrentLocale().getLocaleName(); Line 115: String[] localeNames = LocaleInfo.getAvailableLocaleNames(); -- To view, visit http://gerrit.ovirt.org/28333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic456286d03a906d3cc8c224050504a0f4e4b2d6c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
