Alon Bar-Lev has posted comments on this change. Change subject: core: Configure fence_kdump during host deploy ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28386/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-06-05 11:47:20 +0200 Line 4: Commit: Martin Perina <mper...@redhat.com> Line 5: CommitDate: 2014-06-05 11:50:50 +0200 Line 6: Line 7: core: Configure fence_kdump during host deploy host-deploy: please Line 8: Line 9: Sets parameters for kdump plugin in host deploy, so fence_kdump will be Line 10: properly configured during host deploy for hosts with enabled kdump Line 11: detection. http://gerrit.ovirt.org/#/c/28386/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java: Line 568: new Callable<Boolean>() { public Boolean call() throws Exception { Line 569: _parser.cliEnvironmentSet( Line 570: KdumpEnv.ENABLE, Line 571: _vds.isPmKdumpDetection() Line 572: ); you should get the status from remote, then decide if to enable Line 573: return true; Line 574: }}, Line 575: new Callable<Boolean>() { public Boolean call() throws Exception { Line 576: String destinationAddress = Config.<String>getValue(ConfigValues.FenceKdumpDestinationAddress); -- To view, visit http://gerrit.ovirt.org/28386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc12188588a6a35b8f03d26a9ee5ea55898943df Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
