Vojtech Szocs has posted comments on this change. Change subject: webadmin: DialogTab implemets HasEnabled ......................................................................
Patch Set 2: Nice patch Gilad! Few comments :) - maybe method name "disable" -> "updateEnabled"? - "content instanceof ComplexPanel" -> "content instanceof IndexedPanel" (interface)? - what happens if some editor widgets should be disabled (e.g. their model is not changeable)? [we would override the effect of UiCommonEditorVisitor.onIsChangablePropertyChange] -- To view, visit http://gerrit.ovirt.org/5384 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba73e9592ecbde33102f807dffaeaa44d3d9a746 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
