Shahar Havivi has posted comments on this change. Change subject: core: Extract hardcoded strings to constants ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/28281/5/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java File backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmConditionFieldAutoCompleter.java: Line 18: public static final String COMMENT = "COMMENT"; Line 19: public static final String STATUS = "STATUS"; Line 20: public static final String HOST = "HOST"; Line 21: public static final String IP = "IP"; Line 22: public static final String FQDN = "FQDN"; > but maybe it's confusing because its used in the follow up patch. maybe i s Yes, it will be best to put it in the following patch, (you will not get findbugs error) Line 23: public static final String UPTIME = "UPTIME"; Line 24: public static final String OS = "OS"; Line 25: public static final String CREATIONDATE = "CREATIONDATE"; Line 26: public static final String ADDRESS = "ADDRESS"; -- To view, visit http://gerrit.ovirt.org/28281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d2fb964cc0c5520e37cd190e88f09d4218868d2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
