Martin Mucha has posted comments on this change. Change subject: core,restapi: removed separator inconsistency, removed duplicates. ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28343/2/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java File backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/QueryHelper.java: Line 45: public class QueryHelper { Line 46: Line 47: public static final String CONSTRAINT_PARAMETER = "search"; Line 48: Line 49: //when changing please keep consistent with org.ovirt.engine.core.searchbackend.SearchObjects.SAFE_EXPRESSION_SEPARATOR > Why not to use the same one ? Or better, extract the method which construct maybe I'm wrong, but I tried it and those modules probably cannot see one to each other. Or it seems that this is the case. If that's true, and we can place it to one generally accessible place, tell me where to put that constant. That of course proper solution. Line 50: public static final String RETURN_TYPE_SEPARATOR = " : "; Line 51: Line 52: public static final String CURRENT_CONSTRAINT_PARAMETER = "current"; Line 53: -- To view, visit http://gerrit.ovirt.org/28343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2c72e0527f084e1453da7f720a23fe84dd94db6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
