Yair Zaslavsky has posted comments on this change. Change subject: engine: Introduction of command entity dao ......................................................................
Patch Set 28: (3 comments) http://gerrit.ovirt.org/#/c/26337/28/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 1664: /** @return The type of task that should be created for this command. Line 1665: * Commands that do not create async tasks return notsupported Line 1666: **/ Line 1667: protected AsyncTaskType getTaskType() { Line 1668: return AsyncTaskType.notsupported; s/notsupported/notSupported thanks! Line 1669: } Line 1670: Line 1671: public AsyncTaskType getAsyncTaskType() { Line 1672: if (getTaskType() == AsyncTaskType.notsupported) { http://gerrit.ovirt.org/#/c/26337/28/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/EndActionCallBack.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/interfaces/EndActionCallBack.java: Line 2: Line 3: import org.ovirt.engine.core.bll.job.ExecutionContext; Line 4: import org.ovirt.engine.core.common.action.VdcReturnValueBase; Line 5: Line 6: public interface EndActionCallBack { Hi , I know a bit late in the game,sorry for that :) but another thought that came to my mind - feel free to disagree :) Maybe we would like to have a single callback interface for commands, nad have endAction as a method in it? Line 7: public VdcReturnValueBase endAction(SPMTask task, ExecutionContext context); http://gerrit.ovirt.org/#/c/26337/28/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskType.java: Line 12: syncImageData, Line 13: extendImageSize, Line 14: downloadImage, Line 15: downloadImageFromStream, Line 16: notsupported; see previous comment - should be notSupported. also maybe worth commenting here what "notSupported" means? Line 17: Line 18: public int getValue() { Line 19: return this.ordinal(); Line 20: } -- To view, visit http://gerrit.ovirt.org/26337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I463102d85de7558fbcab23585ad6b48cdc35c0a0 Gerrit-PatchSet: 28 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
