Federico Simoncelli has uploaded a new change for review.
Change subject: core: fix canDoAction check in RemoveStoragePoolCommand
......................................................................
core: fix canDoAction check in RemoveStoragePoolCommand
After change 60cbca3 (core: Detach storage domain when remove Storage
Pool) trying to remove a datacenter without any storage domain resulted
in a IndexOutOfBoundsException.
Change-Id: I209fea6f4a8c9da74a3725ef539442446914de9c
Signed-off-by: Federico Simoncelli <fsimo...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/28377/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
index 02e0ef5..7eb78bd 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
@@ -323,7 +323,7 @@
if(poolDomains.size() > 1) {
return
failCanDoAction(VdcBllMessages.ERROR_CANNOT_REMOVE_STORAGE_POOL_WITH_NONMASTER_DOMAINS);
}
- if (!canDetachStorageDomainWithVmsAndDisks(poolDomains.get(0))) {
+ if (!poolDomains.isEmpty() &&
!canDetachStorageDomainWithVmsAndDisks(poolDomains.get(0))) {
return false;
}
} else {
--
To view, visit http://gerrit.ovirt.org/28377
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I209fea6f4a8c9da74a3725ef539442446914de9c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
