Jason Liao has posted comments on this change. Change subject: restapi: NUMA feature restful API support ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/26943/9/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmNumaNodesResource.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmNumaNodesResource.java: Line 28: @DELETE Line 29: @Path("{id}") Line 30: public Response remove(@PathParam("id") String id); Line 31: Line 32: @Path("{iden}") > iden? It means id, but in same interface, the Path can not be repeated, the remove method use it ({id}). Line 33: public VmNumaNodeResource getVmNumaNodeSubResource(@PathParam("iden") String id); http://gerrit.ovirt.org/#/c/26943/9/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 4208: <xs:sequence> Line 4209: <xs:element ref="host" minOccurs="0" maxOccurs="1"/> Line 4210: <xs:element name="index" type="xs:int" minOccurs="0" maxOccurs="1"/> Line 4211: <xs:element name="memory" type="xs:long" minOccurs="0" maxOccurs="1"/> Line 4212: <xs:element name="cpu" type="CPU" minOccurs="0" maxOccurs="1"/> > should it be CPUs (plural?) The CPU model in restful API is already mean the CPUs (plural), it contains CPU topology and others. You can check it. Line 4213: <xs:element name="statistics" type="Statistics" minOccurs="0" maxOccurs="1"/> Line 4214: <xs:element name="node_distance" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 4215: </xs:sequence> Line 4216: </xs:extension> Line 4281: <jaxb:property generateIsSetMethod="false"/> Line 4282: </xs:appinfo> Line 4283: </xs:annotation> Line 4284: </xs:attribute> Line 4285: <xs:attribute name="index" type="xs:int" use="required"/> > no need a ref to HostNuma? I am not sure we could add this link, I will try it Line 4286: </xs:complexType> Line 4287: Line 4288: <xs:complexType name="Cores"> Line 4289: <xs:sequence> -- To view, visit http://gerrit.ovirt.org/26943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72ed4b16c220decbf640f74c4aadffe423afc290 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jason Liao <chuan.l...@hp.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Xiaolei Shi <xiao-lei....@hp.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
