Yair Zaslavsky has posted comments on this change. Change subject: aaa: AuthenticationProfileRepository to become observer of ExtensionsManager ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/28309/2/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationProfileRepository.java: Line 56 Line 57 Line 58 Line 59 Line 60 > BTW: do we need this public? Done Line 82: if (authzName == null) { Line 83: throw new ConfigurationException(String.format("Authz plugin for %1$s does not exist", Line 84: authnExtension.getContext().<String> get(Base.ContextKeys.INSTANCE_NAME))); Line 85: } Line 86: registerProfile(results, > try to write 1st parameter within own line... if the 2nd parameter is alrea Done Line 87: new AuthenticationProfile( Line 88: authnExtension, Line 89: EngineExtensionsManager.getInstance().getExtensionByName(authzName), Line 90: mapperName != null ? EngineExtensionsManager.getInstance().getExtensionByName(mapperName) : null Line 95: } Line 96: Line 97: private void registerProfile(Map<String, AuthenticationProfile> map, AuthenticationProfile profile) { Line 98: map.put(profile.getName(), profile); Line 99: } > not sure why private oneliner has benefit. either that or having a local variable for profile. as i need both the profile and its name when putting to the map. i'll change to local variable Line 100: Line 101: @Override Line 102: public void update(Observable o, Object arg) { Line 103: profiles = createProfiles(); -- To view, visit http://gerrit.ovirt.org/28309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie201fa985eb412f47fe492695b79afee21de66f8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
