Darshan N has posted comments on this change. Change subject: ovirt-log-collector:Fix: Ask password before engine log collection. ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28065/2/src/__main__.py File src/__main__.py: Line 1667: try: Line 1668: if not conf.get("no_hypervisor"): Line 1669: hosts_present = collector.set_hosts() Line 1670: except Exception as e: Line 1671: pass > This looks reasonable. However, I would like to know if you have verified yes, I have verified that scenario .It collects engine and db log even when jBoss is down. Line 1672: collector.get_engine_data() Line 1673: collector.get_postgres_data() Line 1674: if hosts_present: Line 1675: collector.get_hypervisor_data() -- To view, visit http://gerrit.ovirt.org/28065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e49f3196f5dc5076fe784d7819160dba24e0184 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@gmail.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
