Simone Tiraboschi has posted comments on this change. Change subject: dwh: Split of engine-setup-plugin ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/28242/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/system/environment.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/system/environment.py: Line 58: ) Line 59: self.environment.setdefault( Line 60: odwhcons.SystemEnv.GROUP_DWH, Line 61: dwhGroup Line 62: ) > right I moved the constant back to constants.py and this code to base cause it seams that also the websocket proxy needs it. Line 63: Line 64: -- To view, visit http://gerrit.ovirt.org/28242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e53dd09940697fe6ef73ed63ef4369e73b02c42 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
