Yair Zaslavsky has posted comments on this change. Change subject: engine : Rebalance & Remove-brick stop to return status ......................................................................
Patch Set 10: (2 comments) @Sahina, @Piotr, Do we expect gluster features to align against Pitor's work on JSON RPC? http://gerrit.ovirt.org/#/c/28165/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java: Line 135: public GlusterBrickValidator getBrickValidator() { Line 136: return new GlusterBrickValidator(); Line 137: } Line 138: Line 139: protected GlusterVolumeTaskStatusEntity updateStatusEntity(GlusterVolumeTaskStatusEntity status) { something is wong with the indentation, please fix. Line 140: // Set the volume remove bricks start time Line 141: setStartAndStopTime(status); Line 142: // update the latest status Line 143: updateLatestStatus(status); Line 150: taskStatus.sort(); Line 151: return taskStatus; Line 152: } Line 153: Line 154: private GlusterVolumeTaskStatusEntity setStartAndStopTime(GlusterVolumeTaskStatusEntity status) { same. Line 155: if (status == null) { Line 156: return null; Line 157: } Line 158: -- To view, visit http://gerrit.ovirt.org/28165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic91f437bd40b43f24f19d23a47297ae78dbd9372 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
