Tomas Jelinek has uploaded a new change for review. Change subject: userportal,webadmin: Remove redundant scroll bar in VM general tab ......................................................................
userportal,webadmin: Remove redundant scroll bar in VM general tab The ProfilesInstanceTypeEditor had the vertical size hardcoded and was wrapped by a ScrollPanel. This caused the redundant scroll bar in the VM general tab to appear. Fixed by removing the ScrollPanel since in all other tabs in the VM dialog the scrolling is handled by the dialog itself - this change makes the behavior consistent with the rest of the tabs. It has been already fixed in http://gerrit.ovirt.org/#/c/26169 but has been accidentally introduced back in http://gerrit.ovirt.org/#/c/24594 so this patch removes it again. Change-Id: I03f31624feaa23b37006310d365d57e717d4bbb0 Bug-Url: https://bugzilla.redhat.com/1047883 Signed-off-by: Tomas Jelinek <tjeli...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/98/28298/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml index 99c240c..90323fe 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.ui.xml @@ -29,9 +29,7 @@ <g:FlowPanel addStyleNames="{style.mainPanel}" > <g:Label ui:field="headerLabel" text="{constants.assignNics}" addStyleNames="{style.headerLabel}" /> - <g:ScrollPanel height="190px"> - <g:FlowPanel ui:field="contentPanel" addStyleNames="pite_content_pfly_fix"/> - </g:ScrollPanel> + <g:FlowPanel ui:field="contentPanel" addStyleNames="pite_content_pfly_fix"/> </g:FlowPanel> </ui:UiBinder> -- To view, visit http://gerrit.ovirt.org/28298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I03f31624feaa23b37006310d365d57e717d4bbb0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
