Alon Bar-Lev has posted comments on this change. Change subject: aaa: Introducing usage of Acct ......................................................................
Patch Set 16: (3 comments) http://gerrit.ovirt.org/#/c/27070/16/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java: Line 188: null, Line 189: null, Line 190: null, Line 191: "Invalid user was passed. Credentials based authentication has failed" Line 192: ); > how? i don't have the user name here. so what failing? Line 193: return false; Line 194: } Line 195: String password = getParameters().getPassword(); Line 196: if (password == null) { Line 202: Acct.ReportReason.PRINCIPAL_CREDENTIALS_INVALID, Line 203: null, Line 204: null, Line 205: null, Line 206: "Invalid credentials were passed. Credentails based authentication has failed" > you don't have here a password, i would like to report that. if you do not attempt login, I do not think it worth to report.... acct is not log, these are security events. Line 207: ); Line 208: return false; Line 209: } Line 210: http://gerrit.ovirt.org/#/c/27070/16/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Acct.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/aaa/Acct.java: Line 117: * Will have {@link PrincipalRecord}. Line 118: */ Line 119: public static final int PRINCIPAL_CREDENTIALS_CHANGED = 12; Line 120: /** Line 121: * Invalid credentials. > will it always have principal record? yes, as you need to fill the user, no? this is the principal record of acct... Line 122: */ Line 123: public static final int PRINCIPAL_CREDENTIALS_INVALID = 13; Line 124: /** Line 125: * Access denied. -- To view, visit http://gerrit.ovirt.org/27070 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief13d233d11b7ab32b328735b4f58ec7cffff567 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
