Omer Frenkel has posted comments on this change. Change subject: core: refactor ProcessDownVmCommand ......................................................................
Patch Set 9: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28146/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessDownVmCommand.java: Line 67: removeVmStatelessImages(); Line 68: } Line 69: Line 70: QuotaManager.getInstance().rollbackQuotaByVmId(getVmId()); Line 71: VmHandler.removeStatelessVmUnmanagedDevices(getVmId()); we should consider moving this method here and make it local private Line 72: Line 73: applyNextRunConfiguration(); Line 74: } Line 75: -- To view, visit http://gerrit.ovirt.org/28146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0325e208aa9a76ad859ffff502d02e89f0001caa Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
